[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

[Shaurya Gupta via Phabricator via cfe-commits]

SureYeaah marked an inline comment as done.
SureYeaah added inline comments.


================
Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51
+    /// The Length of the selection
+    unsigned SelectionLength;
     /// The AST nodes that were selected.
----------------
kadircet wrote:
> maybe expose a `SourceLocation SelectionEnd` ?
Should I also have a SelectionStart? Or just use Cursor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64912/new/

https://reviews.llvm.org/D64912



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits