sammccall added inline comments.
================ Comment at: clang/test/Index/complete-qualified-with-preamble.cpp:7 +// START-OF-LINE: Class +// -- With preambles. +// RUN: CINDEXTEST_EDITING=1 c-index-test -code-completion-at=%s:3:1 %s \ ---------------- ilya-biryukov wrote: > sammccall wrote: > > Nit: This (and the filename) seems like a nonstandard use of "preamble" - > > is there precedent for this in ASTUnit? > > > > Else maybe these are just "cached global completions" or something > Good point, this is focused on cached completions, not preambles. Renamed the > file and update the comments. > > There seem to be other tests mentioning preamble in `test/Index`. Though I'm > not sure myself `CINDEXTEST_EDITING=1` affects **only** whether preambles are > being used, my knowledge here is definitely not very deep. Thanks for the rename. Looking at the implementation, CINDEXTEST_EDITING enables both preambles and completion caching, but they're separate features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64918/new/ https://reviews.llvm.org/D64918 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
