peter.smith added a comment.
Thanks for the update. Will be worth adding some reviewers from Apple to see if
this change should be IsAAPCS only. I've no more further comments myself
besides a small nit on style.
================
Comment at: lib/Basic/Targets/ARM.cpp:331
+ // but Android ABI uses 128-bit alignment as default
+ DefaultAlignForAttributeAligned =
+ (Triple.getEnvironment() == llvm::Triple::Android)?128:64;
----------------
Nit: suggest running clang-format over the conditional expression I think that
spaces are needed around ? and :
The previous bit of code used
```
if (IsAAPCS && (Triple.getEnvironment() != llvm::Triple::Android))
MaxVectorAlign = 64;
```
The IsAAPCS could be important here as on Macho targets IsAAPCS may not be
true, see calls to setABI in ARMTargetInfo::ARMTargetInfo.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65000/new/
https://reviews.llvm.org/D65000
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
