anton-afanasyev added inline comments.
================ Comment at: clang/docs/ClangCommandLineReference.rst:1951 + +Minimum time granularity (in microseconds) traced by time profiler + ---------------- sammccall wrote: > is there any possibility of wanting a granularity <1ms in the future? This > sets up a backward-compatibility trap if so. Does it really make sense? One can use `-ftime-trace-granularity=0`, which can show all events. ================ Comment at: llvm/lib/Support/TimeProfiler.cpp:27-30 +// Minimum time granularity (in microseconds) traced by time profiler +unsigned TimeTraceGranularity = 500; TimeTraceProfiler *TimeTraceProfilerInstance = nullptr; ---------------- lebedev.ri wrote: > Can `TimeTraceGranularity` perhaps be stored in `TimeTraceProfilerInstance`? Sure, thanks. ================ Comment at: llvm/lib/Support/TimeProfiler.cpp:28 +// Minimum time granularity (in microseconds) traced by time profiler +unsigned TimeTraceGranularity = 500; ---------------- sammccall wrote: > sammccall wrote: > > why does this have a default value? It shouldn't be possible to use it > > without overwriting it, IIUC > static Moved to `struct TimeProfiler` member. ================ Comment at: llvm/lib/Support/TimeProfiler.cpp:28 +// Minimum time granularity (in microseconds) traced by time profiler +unsigned TimeTraceGranularity = 500; ---------------- anton-afanasyev wrote: > sammccall wrote: > > sammccall wrote: > > > why does this have a default value? It shouldn't be possible to use it > > > without overwriting it, IIUC > > static > Moved to `struct TimeProfiler` member. Hmm, ok, removing default value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65202/new/ https://reviews.llvm.org/D65202 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
