aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
================
Comment at: clang/lib/Sema/SemaChecking.cpp:11656
+ IsListInit =
+ IsListInit || (isa<InitListExpr>(OrigE) && S.getLangOpts().CPlusPlus);
+
----------------
ziangwan wrote:
> aaron.ballman wrote:
> > Do you want to perform the `isa<>` on `OrigE` or on `E` which has had paren
> > and implicit casts stripped?
> When we are dealing with Initialization list syntax expression, the out-most
> expression will be of type `InitListExpr`. Since the out-most expression is
> not `ImplicitCastExpr`, `IgnoreParenImpCasts()` has no effect on the `OrigE`
> object. In other words, `OrigE` and `E` will be the same when
> `isa<InitListExpr>(OrigE)` evaluates to true.
>
> In this case, I personally prefer `OrigE` since it is the "non-processed"
> object. However, the rest of the function uses `E` only. I can change it to
> `E`.
Ah, I was thinking we had to contend with a case like `({1, 2, 3})` where
there's a `ParenExpr` involved, but I am not certain that's a case we have to
worry about.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64666/new/
https://reviews.llvm.org/D64666
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
