shafik added a comment. Thank you for writing this up! I just have a few minor comments.
================ Comment at: clang/docs/LibASTImporter.rst:110 + +Now we create the Importer and do the import: + ---------------- Maybe helpful to link to the [Matching the Clang AST](https://clang.llvm.org/docs/LibASTMatchers.html) and [AST Matcher Reference](https://clang.llvm.org/docs/LibASTMatchersReference.html) ================ Comment at: clang/docs/LibASTImporter.rst:283 +However, there may be cases when both of the contexts have a definition for a given symbol. +If these definitions differ then we have a name conflict, otherwise known as ODR (one definition rule) violation. +Let's modify the previous tool we had written and try to import a ``ClassTemplateSpecializationDecl`` with a conflicting definition: ---------------- Note ODR is a C++ concept C does not have ODR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65573/new/ https://reviews.llvm.org/D65573 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
