chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land.
LGTM with two nits addressed, thanks! ================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:1125 + PB.addPGOInstrPassesForO0(MPM, CodeGenOpts.DebugPassManager, + /* RunProfileGen */ PGOOpt->Action == + PGOOptions::IRInstr, ---------------- Minor nit, here and else where with the comment-named bools I'd use the style: `/*RunProfileGen=*/PGOOpt->Action == PGOOPtions::IRInstr` This was suggested as more consistent w/ Clang style, and it seems a bit cleaner. Also, clang-tidy will recognize and check that the comment uses the same name as the parameter. ================ Comment at: llvm/lib/Passes/PassBuilder.cpp:1839 + addPGOInstrPassesForO0(MPM, DebugLogging, + /* RunProfileGen */ + PGOOpt->Action == PGOOptions::IRInstr, ---------------- Same nit about the parameter comments here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64029/new/ https://reviews.llvm.org/D64029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
