ilya-biryukov added a comment.

The fix looks good.



================
Comment at: 
clang/unittests/Tooling/RecursiveASTVisitorTests/InitListExprPreOrder.cpp:17
 // syntactic and semantic form.
 class InitListExprPreOrderVisitor
     : public ExpectedLocationVisitor<InitListExprPreOrderVisitor> {
----------------
Could you create a new test?
This test is clearly meant to test only `InitListExpr`, we should keep it 
focused on one thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65735/new/

https://reviews.llvm.org/D65735



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to