Manikishan marked an inline comment as done.
Manikishan added inline comments.


================
Comment at: unittests/Format/FormatTest.cpp:3663
+  FormatStyle Style = getGoogleStyle();
+  Style.SpacesBeforeTrailingComments = 0;
   EXPECT_EQ("#define MACRO()                     \\\n"
----------------
MyDeveloperDay wrote:
> this feels odd, suggesting those using google style will get reformatted 
> changes?
Yes, so in that case shall I add a new style variable like 
spacesBeforeTrailingBlockComments. Using which they can enable the style. This 
also supports new styles which need. spaces before Block Comments and styles 
which doesn't need spaces.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65648/new/

https://reviews.llvm.org/D65648



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D65648: [cla... Manikishan Ghantasala via Phabricator via cfe-commits
    • [PATCH] D65648:... MyDeveloperDay via Phabricator via cfe-commits
    • [PATCH] D65648:... Manikishan Ghantasala via Phabricator via cfe-commits

Reply via email to