alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one possible improvement. Thank you!
================
Comment at: clang-tidy/readability/BracesAroundStatementsCheck.cpp:181
@@ +180,3 @@
+ // IfStmt. Avoid triggering assert failure.
+ if (isa<OpaqueValueExpr>(S->getCond()))
+ return SourceLocation();
----------------
Maybe just replace the assertion with
if (!CondEndLoc.isValid())
return SourceLocation();
?
Repository:
rL LLVM
http://reviews.llvm.org/D17069
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
