ruiu marked an inline comment as done. ruiu added inline comments.
================ Comment at: clang/tools/diagtool/TreeView.cpp:167 + if (!hasColors(out)) + out.enable_colors(false); + ---------------- MaskRay wrote: > `out.enable_colors(out.has_colors());` > > It looks the function `hasColors` is overengineered. `out` in these files can > only be `llvm::outs()`. It doesn't have to check if `llvm::errs()` is > connected to a terminal. Done. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65854/new/ https://reviews.llvm.org/D65854 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
