Eugene.Zelenko added a comment. I think patch should be split at least on Clang-tidy check and results of its run on LLVM code. Probably per-target patches is even better solution.
================ Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:48 + Replacement = "Register"; + for (const UsingDirectiveDecl *UsingDirective: Context->using_directives()) + if (UsingDirective->getNominatedNamespace() ---------------- You could use const auto * for iterators. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:85 + + Finds historical use of `unsigned` to hold vregs and physregs and rewrites + them to use `Register` ---------------- Please use double back-ticks to highlight language constructs. Same in documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65919/new/ https://reviews.llvm.org/D65919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
