Szelethus closed this revision.
Szelethus marked 5 inline comments as done.
Szelethus added a comment.
The deed is done.
================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:111
+/// getters and some well placed asserts for extra security.
+class BugReportConstruct {
+ /// The consumer we're constructing the bug report for.
----------------
Szelethus wrote:
> NoQ wrote:
> > You mean `Construct` like a noun? Not sure what that means.
> >
> > Maybe `PathDiagnosticContext`?
> Yea, I originally wanted to have the class name `BaconStrip` so that it
> screams just a bit louder that I couldnt come up with anything good, but
> maybe `PathDiagnosticConstruction` or something like that would be better.
Mmmmm this entire class is about non-contextual stuff, I'd rather stick with
`PathDiagnosticConstruct` and just explain it well in the comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:140
+ /// bug path.
+ const LocationContext *getCurrLocationContext() const {
+ assert(CurrentNode && "Already reached the root!");
----------------
NoQ wrote:
> > Curr
>
> Purr? =^.^=
I've always been a cat person. They take care of themselves, just like a good
C++ class should :^)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65484/new/
https://reviews.llvm.org/D65484
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
