juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land.
One comment then LGTM ================ Comment at: clang-tools-extra/clang-doc/Serialize.cpp:507 Reference{ParentUSR, Parent->getNameAsString(), InfoType::IT_record}; - Func.Access = D->getAccess(); + Func.Access = D->getAccessUnsafe(); ---------------- In a C++ method, it should have an access associated with it, and so AS_none isn't a valid value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66151/new/ https://reviews.llvm.org/D66151 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits