xazax.hun added inline comments.
================ Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:172 T &operator*(); + T &value(); +}; ---------------- mgehre wrote: > xazax.hun wrote: > > I actually was a bit lazy when I added these tests. Both `value` and > > `operator*` is overloaded on `&&`. But if you do not feel like adjusting > > the tests this is fine, I can do it myself later :) > I'll change it to use the `&` variant in the test - the `&&` cannot dangle as > far as I understand. It can! Consider the following code: ``` int &&r = *std::optional(5); // r dangles here. ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66164/new/ https://reviews.llvm.org/D66164 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits