ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
Thanks for providing examples of error messages, also agree they look fine. If we find bad error messages later, we could revisit the presentation strategy. LGTM ================ Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:109 + // Keep the default behavior. + if (error instanceof vscodelc.ResponseError && + error.code === vscodelc.ErrorCodes.RequestCancelled) ---------------- Is this how default implementation behaves? Is there a way to call into it instead of re-implementing? If so, it would be nice to do so. If not, I'm also ok if we keep it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66211/new/ https://reviews.llvm.org/D66211 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
