Quuxplusone added a comment.

LGTM too, although I would still question whether 
`Style.SpaceBeforeAssignmentOperators` is providing anyone any benefit at all.



================
Comment at: clang/unittests/Format/FormatTest.cpp:6631
+  verifyFormat("a<int> = 1;", Style);
+  verifyFormat("a<int> >>= 1;", Style);
 
----------------
Actually, could you add a test case specifically for the troublesome 
`enable_if_t` pattern? Just in case any future option treats 
default-template-arguments any differently from assignment-statements, 
whitespace-wise.

    verifyformat("template<enable_if_t<Foo, int> = 0>");



Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66384/new/

https://reviews.llvm.org/D66384



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to