lebedev.ri added a comment. In D64695#1614386 <https://reviews.llvm.org/D64695#1614386>, @MyDeveloperDay wrote:
> Assuming this works and the other unit tests don't show issues then this LGTM. > Please consider running this on your NetBSD code base before committing, if > possible please also run on clang code based to ensure existing sorted > headers aren't sorted unexpectedly. Before this gets committed, i feel like echoing this - did you ensure that this doesn't regress existing code/configs? > I do feel like there could be a documentation change missing really to > explain to people how this really works and what if anything they have to > change in their existing .clang-format files Oh, indeed, docs are completely missing. I think it is best to resolve this right away rather than afterwards. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
