paulkirth marked 2 inline comments as done. paulkirth added inline comments.
================ Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:123 + const uint64_t CaseTotal = std::accumulate( + Weights.begin(), Weights.end(), (uint64_t)0, std::plus<uint64_t>()); + const int NumUnlikelyTargets = Weights.size() - 1; ---------------- nickdesaulniers wrote: > s/(uint64_t)0/0ULL/ might be simpler, but I don't know if `long long == > uint64_t` on every host Clang can be built for... I'm not sure if that is true, either. I think its safe to follow the convention of existing LLVM code doing more or less the same thing, though, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
