vsapsai marked an inline comment as done.
vsapsai added inline comments.
================
Comment at: clang/lib/Serialization/ModuleManager.cpp:211
- if (!getModuleCache().tryToDropPCM(NewModule->FileName))
- FileMgr.invalidateCache(NewModule->File);
return OutOfDate;
----------------
dexonsmith wrote:
> This is the only caller of FileManager::invalidateCache. I suggest deleting
> it in a follow-up, in order to reduce complexity in the FileManager.
Good suggestion. Agree it will be better to keep the FileManager simpler.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66907/new/
https://reviews.llvm.org/D66907
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
