MaskRay added inline comments.
================ Comment at: cfe/trunk/include/clang/Index/IndexingAction.h:58 + const IndexingOptions &Opts, std::shared_ptr<Preprocessor> PP, + std::function<bool(const Decl *)> ShouldSkipFunctionBody); + ---------------- I know ShouldSkipFunctionBody is important for multi-threaded indexing, but why is it a mandatory argument? There are lots of other overloads, are they good candidates for being mandatory arguments? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66879/new/ https://reviews.llvm.org/D66879 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
