rsmith added a comment.

In D64799#1608085 <https://reviews.llvm.org/D64799#1608085>, @ilya-biryukov 
wrote:

> @rsmith two options for this patch seem to be:
>
> - silently ignore the errors (behavior before this patch),
> - show them to the user at the end of TU (what happens in the current version 
> of the patch). This can result in bad UX, but we won't drop any errors on the 
> floor. Which one do you think we should prefer?


Let's take the second option. It seems better to diagnose an error late than 
not at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64799/new/

https://reviews.llvm.org/D64799



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D64799: [... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to