shafik added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:3454
<< FoundField->getType();
-
+ // This case is not handled with HandleNameConflict, because by the time
+ // when we reach here, the enclosing class is already imported. If there
----------------
Do we have an example that hits this case?
================
Comment at: clang/lib/AST/ASTImporter.cpp:5262
+ // template.
+ // FIXME Perhaps return with a different error?
return make_error<ImportError>(ImportError::NameConflict);
----------------
I believe this is ill-formed no diagnostic required.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66999/new/
https://reviews.llvm.org/D66999
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
