RKSimon added a comment. In D64672#1654983 <https://reviews.llvm.org/D64672#1654983>, @craig.topper wrote:
> In D64672#1654687 <https://reviews.llvm.org/D64672#1654687>, @RKSimon wrote: > > > Tests look great - please can you pre-commit them and update the patch to > > show the diff? Also, maybe call the test file x86-vec-i128.c and add a > > comment in the file describing PR42607? > > > How do you want me to show the diff? There a couple options. Three of the > check lines have to be removed from the pre-commit since they use a command > line option that doesn't exist. Do you want me to change the check lines that > say NEWABI to use the old code? Or do you want me to manipulate the FileCheck > command lines to use the OLDABI check lines? How about CLANG9ABI and CLANG10ABI? And the patch just adds the -fclang-abi-compat=9 tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
