ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land.
LGTM with one small change. ================ Comment at: clang/test/Sema/arm_inline_asm_constraints.c:47 +// I: An immediate integer valid for a data-processing instruction. (ARM/Thumb2) +// An immediate integer between -255 and -1. (Thumb1) +int test_I(int i) { ---------------- Copy-paste error, should be "between 0 and 255". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65863/new/ https://reviews.llvm.org/D65863 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits