aaron.ballman added a comment. In D66919#1655052 <https://reviews.llvm.org/D66919#1655052>, @aaronpuchert wrote:
> In D66919#1655048 <https://reviews.llvm.org/D66919#1655048>, @dexonsmith > wrote: > > > I went back to read notes from when we deployed `-Wstrict-prototypes` > > (which we have had on-by-default for our users for a couple of years, since > > it catches lots of `-fblocks`-related bugs). I was mainly objecting > > because I had (mis)remembered trying and backing out the specific behaviour > > you're adding. On the contrary, our notes say that we might want to > > strengthen the diagnostic as you're doing. > > > Thank you for having a look at the notes, that's good to hear. > > Your users are Xcode/Apple Clang users? @aaron.ballman suggested to turn the > warning on per default, and if Apple has that deployed already, it might be > another argument in favor of doing so in vanilla Clang as well. We do have numerous warnings that are default errors, you can look for `DefaultError` in the diagnostic .td files to see the uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66919/new/ https://reviews.llvm.org/D66919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
