ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed.
Does the name of the `-falways-need-cfi` option match any existing compiler (google doesn't find anything)? If not, I think it would make more sense as a `-g` option, as it's similar to `-gline-tables-only`. ================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:956 OPT_fno_unique_section_names, true); + Opts.AlwaysNeedCFI = + Args.hasFlag(OPT_falways_need_cfi, OPT_fno_always_need_cfi, false); ---------------- Is this option actually being read anywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67216/new/ https://reviews.llvm.org/D67216 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits