Szelethus added a comment.
Niiiiice! Thank you so much for sorting this out! I think this will make
reviewing far more accessible for newcomers to the IteratorChecker family. I
have a couple nits to comment on, but I won't clutter the code just yet. @NoQ,
do you have any high level objections to this?
================
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1689
+ if (CE->getNumArgs() == 0) {
+ reportDebugMsg("Missing container argument", C);
+ return;
----------------
Ah, right, so this would fire for `clang_analyzer_iterator_position()`?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67156/new/
https://reviews.llvm.org/D67156
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
