aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Aside from a minor nit, this LGTM. However, I'm not the most familiar with how cross-compiling works in the first place, so I may be the wrong one to approve this. ================ Comment at: clang/lib/Frontend/InitHeaderSearch.cpp:141-143 + if (HasSysroot) { + if (MappedPathStr.startswith("/usr/include") || + MappedPathStr.startswith("/usr/local/include")) { ---------------- These should be combined into a single if statement: ``` if (HasSysroot && (MappedPathStr.startswith(...) || MappedPathStr.startswith(...))) { ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits