kousikk added a comment. > I was unable to reproduce the failures when I moved the check to createFile. > What kind of failures did you see? Did you move it right to the start of the > function? I would recommend rebasing the patch and retrying.
I saw an assertion error - but I realize now that it was because it was not at the top of the function. I had put it after `Entry->getContents()` which was throwing an assertion. I now realize that for `getContents()` to work, the entry needs to be a file. Thanks for correcting me! > Also, could you please rename headerwithdirname.cpp to > headerwithdirname_input.cpp when copying it to ensure FileCheck can match the > filename without matching the temporary path (see > https://reviews.llvm.org/D67379 for test fixes that @jkorous applied). Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
