kiranchandramohan added a comment.
Some minor comments about Filetypes and file extensions. Can be ignored or
considered for a separate commit.
================
Comment at: clang/include/clang/Driver/Driver.h:69
+ CLMode,
+ FlangMode,
} Mode;
----------------
Is the comma by choice?
================
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:37
+ if (isa<AssembleJobAction>(JA)) {
+ CmdArgs.push_back("-emit-obj");
+ } else if (isa<PreprocessJobAction>(JA)) {
----------------
peterwaller-arm wrote:
> richard.barton.arm wrote:
> > F18 does not currently support these options that control the output like
> > -emit-llvm and -emit-obj so this code doesn't do anything sensible at
> > present. Would it not make more sense to add this later on once F18 or
> > llvm/flang grows support for such options?
> I've removed them.
Can it be removed from the Summary of this PR?
================
Comment at: clang/lib/Driver/Types.cpp:220
+
+ case TY_Fortran: case TY_PP_Fortran:
+ return true;
----------------
Now that there is a 2018 standard, I am assuming that f18 and F18 are also
valid fortran extensions. Can these be added to the File types?
Also, should the TypeInfo file be extended to handle all Fortran file types?
./include/clang/Driver/Types.def
Also, should we capture some information about the standards from the filename
extension?
================
Comment at: clang/test/Driver/lit.local.cfg:1
-config.suffixes = ['.c', '.cpp', '.h', '.m', '.mm', '.S', '.s', '.f90', '.f95',
+config.suffixes = ['.c', '.cpp', '.h', '.m', '.mm', '.S', '.s', '.f90',
'.F90', '.f95',
'.cu', '.rs', '.cl', '.hip']
----------------
For completion .F95 also?
Should we add f03,F03,f08,F08,f18,F18. May be not now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63607/new/
https://reviews.llvm.org/D63607
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
