ymandel added a comment.

In D66652#1654585 <https://reviews.llvm.org/D66652#1654585>, @gribozavr wrote:

> > So, I plan to rework this into two revisions: one to match 
> > https://reviews.llvm.org/D66676 (and keep the tests esssentially as they 
> > are) and one to add getRuleMatchLoc for future use.
>
> That SGTM.
>
> I don't have an opinion about whether they should be separate revisions or 
> not.


Reworked, per our discussion. I kept it in one revision, because I ended up 
useing the new function in this code (for error reporting).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66652/new/

https://reviews.llvm.org/D66652



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to