I'm just wondering, was this not caught in `ninja check-clang` before the patch that added the warning landed?
On Mon, Sep 30, 2019 at 11:39 PM David Bolvansky via cfe-commits <cfe-commits@lists.llvm.org> wrote: > > Author: xbolva00 > Date: Mon Sep 30 13:41:56 2019 > New Revision: 373258 > > URL: http://llvm.org/viewvc/llvm-project?rev=373258&view=rev > Log: > [NFC] Fix tests, second try > > Modified: > cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp > > Modified: cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp?rev=373258&r1=373257&r2=373258&view=diff > ============================================================================== > --- cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp (original) > +++ cfe/trunk/test/SemaCXX/warn-sign-conversion.cpp Mon Sep 30 13:41:56 2019 > @@ -70,15 +70,15 @@ namespace test2 { > int d1 = 1 ? i : Foo<bool>::D; // expected-warning {{operand of ? > changes signedness: 'test2::Foo<bool>::Named4' to 'int'}} > int d2 = 1 ? Foo<bool>::D : i; // expected-warning {{operand of ? > changes signedness: 'test2::Foo<bool>::Named4' to 'int'}} > int d3 = 1 ? B : Foo<bool>::D; // expected-warning {{operand of ? > changes signedness: 'test2::Foo<bool>::Named4' to 'int'}} > - // expected-warning@+1 {{enumeration type mismatch in conditional > expression ('test2::Named2' and 'test2::Foo<bool>::Named4')}} > + // expected-warning@-1 {{enumeration type mismatch in conditional > expression ('test2::Named2' and 'test2::Foo<bool>::Named4')}} > int d4 = 1 ? Foo<bool>::D : B; // expected-warning {{operand of ? > changes signedness: 'test2::Foo<bool>::Named4' to 'int'}} > - // expected-warning@+1 {{enumeration type mismatch in conditional > expression ('test2::Foo<bool>::Named4' and 'test2::Named2')}} > + // expected-warning@-1 {{enumeration type mismatch in conditional > expression ('test2::Foo<bool>::Named4' and 'test2::Named2')}} > > int e1 = 1 ? i : E; // expected-warning {{operand of ? changes > signedness: 'test2::Named5' to 'int'}} > int e2 = 1 ? E : i; // expected-warning {{operand of ? changes > signedness: 'test2::Named5' to 'int'}} > int e3 = 1 ? E : B; // expected-warning {{operand of ? changes > signedness: 'test2::Named5' to 'int'}} > - // expected-warning@+1 {{enumeration type mismatch in conditional > expression ('test2::Named5' and 'test2::Named2')}} > + // expected-warning@-1 {{enumeration type mismatch in conditional > expression ('test2::Named5' and 'test2::Named2')}} > int e4 = 1 ? B : E; // expected-warning {{operand of ? changes > signedness: 'test2::Named5' to 'int'}} > - // expected-warning@+1 {{enumeration type mismatch in conditional > expression ('test2::Named2' and 'test2::Named5')}} > + // expected-warning@-1 {{enumeration type mismatch in conditional > expression ('test2::Named2' and 'test2::Named5')}} > } > } > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
