hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
looks good. ================ Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:610 + /*FullyQualifiedName=*/const char *, + /*CurrentNamespace*/ const char *> + Cases[] = { ---------------- nit: I'd use a struct, it is hard to infer the member by reading `get<0>`, `get<1>` (I have to go back to the top) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68024/new/ https://reviews.llvm.org/D68024 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits