yaxunl marked an inline comment as done. yaxunl added inline comments.
================ Comment at: include/clang/Driver/Options.td:606 +def flink_builtin_bitcode : Flag<["-"], "flink-builtin-bitcode">, + Flags<[CC1Option]>, HelpText<"Link builtin bitcode for HIP device compilation.">; +def fno_link_builtin_bitcode : Flag<["-"], "fno-link-builtin-bitcode">; ---------------- tra wrote: > hliao wrote: > > tra wrote: > > > yaxunl wrote: > > > > ashi1 wrote: > > > > > Since this is a more generic approach, we won't need to specify HIP ? > > > > this patch only implemented this option for HIP. If it is used for > > > > other languages, this help text should be updated. > > > Hmm. Cuda currently uses `-nocudalib` for essentially the same purpose > > > (Sort of like `-nostdlib`, but for CUDA). Perhaps we should consolidate > > > all these into `-nogpulib` and alias `-nocudalib` to it. > > how about other relevant options, such as replacing cuda-device-only with > > gpu-device-only or hip-device-only to avoid confusing with CUDA. > We seem to be doing exactly that, only incrementally. In general it does make > sense to consolidate the flags where the functionality is common. > `cuda-device-only`, `cuda_host_only`, `cuda_compile_host_device` and > `cuda-gpu-arch` could be generalized to `gpu-<something>`. > > This should be a separate patch, though. agree CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68300/new/ https://reviews.llvm.org/D68300 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
