krasimir marked 3 inline comments as done.
krasimir added inline comments.
================
Comment at: lib/Format/TokenAnnotator.cpp:1499
+ } else if (Current.isOneOf(tok::identifier, tok::kw_const,
+ tok::kw_noexcept) &&
Current.Previous &&
----------------
MyDeveloperDay wrote:
> I slightly wonder if other training annotations like `override` and `final`
> might also suffer simular to what we saw with {D68481}
I'll check these cases and add appropriate tests etc. in a subsequent patch
(maybe next week).
I think that part of the issue is that the trailing annotations back in the day
where this code was written (7 years ago judging by a few blames) were captured
by the `tok::identifier` case; however since then `C++` and `clang` have
evolved a lot and have extracted separate tokens for these, hence the missing
cases.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68695/new/
https://reviews.llvm.org/D68695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
