kadircet marked 3 inline comments as done. kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:71 + // Index to be passed into Tweak::Selection. + const SymbolIndex *Index = nullptr; + ---------------- ilya-biryukov wrote: > How is this index populated? Each test has to mock it? that's what we usually do with the indexes in the rest of the testing code.(see code completion tests for an example) we might decide to have some defaults if there are a substantial amount of tests making use of the same pattern, wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69165/new/ https://reviews.llvm.org/D69165 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
