hfinkel added a comment.

> I don't see how such warning can help a user. A note about impact of the 
> pragma on performance can be put into documentation. Issuing a warning on 
> every use of the pragma may be annoying.

I definitely agree. Performance may be fine in many cases, and performance may 
not be *relatively* important where the pragma is used. I don't believe that a 
warning should be added for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69272/new/

https://reviews.llvm.org/D69272



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to