hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1525
+TEST_F(DefineOutlineTest, TriggersOnFunctionDecl) {
+ // Not available unless in a header file.
+ EXPECT_UNAVAILABLE(R"cpp(
----------------
nit: please explicitly spell out the FileName, even the default value is
`TestTU.cpp`.
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1548
+
+ ExtraFiles["Test.cpp"] = "";
+ // Basic check for function body and signature.
----------------
Is this needed? It is unclear to me why we need it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69266/new/
https://reviews.llvm.org/D69266
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
