klimek added inline comments.
================ Comment at: clang/www/get_involved.html:94 + + <li>A complete specification: The specification must be sufficient to + understand the design of the feature as well as interpret the meaning of ---------------- Remove "complete" - the explanation afterwards seems sufficient? ================ Comment at: clang/www/get_involved.html:107 + + <li>A long-term support plan: Contributing a non-trivial extension to Clang + implies a commitment to supporting that extension, improving the ---------------- s/non-trivial/substantial/? ================ Comment at: clang/www/get_involved.html:108-109 + <li>A long-term support plan: Contributing a non-trivial extension to Clang + implies a commitment to supporting that extension, improving the + implementation and specification as Clang evolves. The capacity of the + contributor to make that commitment is as important as the commitment ---------------- s/,/and/? ================ Comment at: clang/www/get_involved.html:113 + + <li>A high-quality implementation: The implementation must fit well into + Clang's architecture, follow LLVM's coding conventions, and meet Clang's ---------------- Perhaps: a standard-conforming implementation? ================ Comment at: clang/www/get_involved.html:115-116 + Clang's architecture, follow LLVM's coding conventions, and meet Clang's + quality standards, including high-quality diagnostics and rich AST + representations. This is particularly important for language extensions, + because users will learn how those extensions work through the behavior of the ---------------- "high-quality diagnostics" is a bit unclear "rich AST" that seems to imply a lot of domain knowledge ================ Comment at: clang/www/get_involved.html:120 + + <li>A proper test suite: Extensive testing is crucial to ensure that the + language extension is not broken by ongoing maintenance in Clang. The test ---------------- s/proper// Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69351/new/ https://reviews.llvm.org/D69351 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits