+1 to what Nico said/ping on this. Jian - could you see if these tests could be made portable as Nico's suggested?
On Mon, Oct 14, 2019 at 3:54 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hm, this means the test can't run on non-linux, so if someone breaks it on > e.g. win they won't see the failure. Maybe add a > --target=i386-unknown-linux instead? Then it might pass on all platforms. > > On Mon, Oct 14, 2019 at 6:48 PM Jian Cai via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: jcai19 >> Date: Mon Oct 14 15:51:12 2019 >> New Revision: 374837 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=374837&view=rev >> Log: >> [clang] add requirements to -Wa,-W test cases. >> >> Include linux as a test requirement. >> >> Modified: >> cfe/trunk/test/Driver/as-w-option.c >> >> Modified: cfe/trunk/test/Driver/as-w-option.c >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/as-w-option.c?rev=374837&r1=374836&r2=374837&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/Driver/as-w-option.c (original) >> +++ cfe/trunk/test/Driver/as-w-option.c Mon Oct 14 15:51:12 2019 >> @@ -5,6 +5,9 @@ >> // RUN: not %clang %s -c -o %t.o -integrated-as -Wa,--fatal-warnings >> 2>&1 | FileCheck --check-prefix=CHECK-AS-FATAL %s >> // RUN: not %clang %s -c -o %t.o -fno-integrated-as -Wa,--fatal-warnings >> 2>&1 | FileCheck --check-prefix=CHECK-AS-FATAL %s >> >> +// REQUIRES: clang-driver >> +// REQUIRES: linux >> + >> // CHECK-IAS: "-cc1" {{.*}} "-massembler-no-warn" >> // CHECK-NOIAS: "-W" >> // CHECK-AS-NOWARN-NOT: warning: >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
