whisperity added reviewers: Szelethus, baloghadamsoftware.
whisperity edited subscribers, added: baloghadamsoftware, NoQ; removed:
Szelethus.
whisperity added a comment.
@Szelethus and @baloghadamsoftware are colleagues to me whom are far more
knowledgeable about check development and I want them to see that I want a
review from them. I specifically didn't do an "internal with colleagues"
downstream review with regards to this code.
================
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/AdjacentArgumentsOfSameTypeCheck.cpp:488
+void AdjacentArgumentsOfSameTypeCheck::registerMatchers(MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus)
+ return;
----------------
Eugene.Zelenko wrote:
> Check seems to be useful for C and probably for Objective-C.
I'm not knowledgeable about Objective-C at all to make a decision on how the
"adjacent argument ranges" could be calculated and what mixups are possible. As
for C, should a `cppcoreguidelines-` check be enabled for C? Or you mean we
should allow it to work, and the user will toggle how they see fit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69560/new/
https://reviews.llvm.org/D69560
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
