daltenty added a comment. > I'm actually opposed to that happening, on two fronts. > (2) we already have `LLVM_ENABLE_PLUGINS` why do we also need > `LLVM_SUPPORT_PLUGINS` seems like duplication and bad design.
As I understand it LLVM_ENABLE_PLUGINS is a user-facing option which indicates whether the user wants to build with plugin support. The intention of LLVM_SUPPORT_PLUGINS was as an internal option set by tools which may have plugins and need to be built in a specific way (such as avoiding deadstriping) if plugins are enabled. > (1) dead stripping support is useful independent of plugins, so it is > valuable to have that option be separate We could keep LLVM_NO_DEAD_STRIP as is and have it set by LLVM_SUPPORT_PLUGINS when appropriate. That should accommodate both uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.org/D69356 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
