beanz added a comment. A few comments inline.
================ Comment at: clang/tools/driver/CMakeLists.txt:34 ${tablegen_deps} + SUPPORT_PLUGINS ) ---------------- This is now a behavior change because you're always passing this. You'll want to bring back the conditional statement with a body like: ``` set(support_plugins SUPPORT_PLUGINS) ``` Then instead of passing `SUPPORT_PLUGINS` here you pass `${support_plugins}` ================ Comment at: llvm/cmake/modules/AddLLVM.cmake:787 + if (ARG_SUPPORT_PLUGINS) + set(LLVM_NO_DEAD_STRIP 1) + endif() ---------------- By convention in LLVM we use `On` rather than `1` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://reviews.llvm.org/D69638 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits