rjmccall added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:133
+
+llvm::ConstrainedFPIntrinsic::ExceptionBehavior
+CodeGenFunction::ToConstrainedExceptMD(LangOptions::FPExceptionModeKind Kind) {
----------------
mibintc wrote:
> I added these 2 functions, is this what you have in mind or do you want me to
> write them differently?
Slightly differently, yes, please.
```
static llvm::ConstrainedFPIntrinsic::ExceptionBehavior
getConstrainedExceptionBehavior(LangOptions;:FPExceptionModeKind kind) {
switch (kind) {
case LangOptions::FPE_Ignore:
return llvm::ConstrainedFPIntrinsic::ebIgnore;
// ...rest of cases here...
// no default: should be exhaustive over the enum
}
llvm_unreachable("bad kind");
}
```
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62731/new/
https://reviews.llvm.org/D62731
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
