zinovy.nis added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:152
+
+          if (llvm::Error Err = Repls.add(Repl))
+            llvm_unreachable("An error occured during fix-it replacements");
----------------
Isn't `llvm_unreacheable` too pessimistic? May be use diagnostics instead?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69746/new/

https://reviews.llvm.org/D69746



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to