esakella added a comment. In http://reviews.llvm.org/D17026#356418, @akyrtzi wrote:
> Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored > by VerifyDiagnosticConsumer ? Why specifically change only this two and what > are we going to do with the others ? > This seems more like needing a fix higher up in the stack, not at the > ASTImporter level. Yes I think also that the right thing would be to change it in all the places, but for now we decided to make this change only in these two places which are relevant to the other things I implemented, to see first if this change would be acceptable. http://reviews.llvm.org/D17026 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
