ABataev marked an inline comment as done.
ABataev added inline comments.
================
Comment at: clang/include/clang/Basic/OpenMPKinds.h:56
+ OpenMPContextSelectorKind Ctx, const U &Names)
+ : CtxSet(CtxSet), Ctx(Ctx), Names(Names.begin(), Names.end()) {}
+};
----------------
ABataev wrote:
> jdoerfert wrote:
> > ABataev wrote:
> > > jdoerfert wrote:
> > > > Why do you need a second template version here?
> > > To construct the object when the container Names cannot be created
> > > dieectly using the first constructor (SmallVector and UniqueVector are
> > > not quite compatible in this sence, for example)
> > That can be addressed by changing the first constructor. Why is it an
> > xvalue there and why is the container not const?
> In short, to avoid some extra memory allocation/deallocation. I can make the
> container const, ok.
Tried to make it `const`, it breaks a lot of code and almost impossible to fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69952/new/
https://reviews.llvm.org/D69952
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
