jdoerfert marked 4 inline comments as done. jdoerfert added inline comments.
================ Comment at: clang/test/Driver/fopenmp.c:130-131 +// CHECK-CC1-OPENMPIRBUILDER: "-cc1" +// CHECK-CC1-OPENMPIRBUILDER: "-fopenmp" +// CHECK-CC1-OPENMPIRBUILDER: "-fopenmp-enable-irbuilder" +// ---------------- ABataev wrote: > `CHECK...-SAME`? Sure, will do. ================ Comment at: clang/test/OpenMP/barrier_codegen.cpp:42 +// CLANGCG-NOT: inaccessiblemem +// IRBUILDER: ; Function Attrs: inaccessiblemem_or_argmemonly nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*) ---------------- ABataev wrote: > Not sure about correctness of `inaccessiblemem_or_argmemonly` attribute > applied to this function. Are you sure about this? This is maybe true for the > NVPTX/AMDGCN runtimes but not the generic version of libomp. Fair point. I'll remove it for now but we should come up with a scheme. Maybe communicating the target library and other information to the IRBuilder so we can select based on those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
