hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + SourceLocation SourceLocationBeg = + SM.getMacroArgExpandedLocation(getBeginningOfIdentifier( + RInputs.Pos, SM, AST.getASTContext().getLangOpts())); ---------------- ilya-biryukov wrote: > Why is this different from `prepareRename`, which does not call > `getMacroArgExpandedLocation`? > I didn't change it in this patch, but you raise a good point, `prepareRename` should call `getMacroArgExpandedLocation`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits